From 300MB to 7GB plus a full hang is even worse. Yeah, it’s not a leak, but an infinite traversal bug. In some very rare and not reliably reproducible cases, nested touchables can trigger this bug and completely freeze the app in our case. Adding a fallback `accessibilityLabel` did the trick. - ThreadSky

About ThreadSky

hirbod.dev • 31 days ago

From 300MB to 7GB plus a full hang is even worse. Yeah, it’s not a leak, but an infinite traversal bug. In some very rare and not reliably reproducible cases, nested touchables can trigger this bug and completely freeze the app in our case. Adding a fallback `accessibilityLabel` did the trick.

Comments

hirbod.dev•31 days ago

Generally speaking, I don’t like these automated and expensive lookups. I’d rather have a dev-only warning that forces users to handle accessibility manually. And lookups should bail out fast and have some railguards.

robwalker.co•31 days ago

You can use https://github.com/FormidableLabs/react-native-ama to add those dev-only accessibility warnings. I'm pretty sure that a missing accessibilityLabel is one of the things it would have shouted about.

jamon.dev•31 days ago

Totally agree!

slime.camp•31 days ago

FYI nested touchables are inaccessible as well.

hirbod.dev•31 days ago

Our FeedItem is actually a GestureDetector (handles play/pause and double-tap to like), and the RectButtons are placed on top of it—not even nested in the tree. We do have nested pressables, eg in lists where the whole item opens a sheet, but the avatar inside navigates to the profile instead.

hirbod.dev•31 days ago

But I think I get why this isn’t accessible for screen readers. I’m definitely lacking the skill and knowledge when it comes to this whole topic; the do’s and don’ts.

slime.camp•31 days ago

On mac at least, you can check out the accessibility inspector since it works with the simulator.

I'm definitely not an expert but I think the only way to make nested pressable actions available to accessibility tech would be to expose them as accessibilityActions on the outermost pressable.

slime.camp•31 days ago

BTW I think as long as they aren't nested in the tree they should be OK

Posting Rules

Be respectful to others
No spam or self-promotion
Stay on topic
Follow Bluesky's terms of service

Comments

Posting Rules

Reply