forked the unicorn lint plugin recently. lots of good perf improvements and dropped a few dependencies. many rules ran against the TSESLint repo in half the time 👀 - ThreadSky

43081j.com • 30 days ago

forked the unicorn lint plugin recently.
lots of good perf improvements and dropped a few dependencies.
many rules ran against the TSESLint repo in half the time 👀

Comments

erickarnis.bsky.social•30 days ago

This is really interesting, do you have anything written detailing the changes/perf improvements?

43081j.com•30 days ago

there's a whole bunch of individual changes
one of the big ones is that some rules had multiple listeners visiting same nodes, and some causing megamorphic calls (by changing object shape too often/arbitrarily). also some rules overmatching (visiting a _lot_ of nodes but only caring about a couple)

43081j.com•30 days ago

but we also replaced find-up-simple with empathic, which itself speeds up package-json resolution a huge amount. we should be doing that everywhere tbh

also just straight up rewrote some visitors to have more performant algorithms

aslemammad.bsky.social•22 days ago

you're a magician 🧙

ematipico.xyz•30 days ago

The original authors weren't interested in the optimisations?

ethangthereal.bsky.social•22 days ago

Read the discussions in the repo. This fork isn't really doing much of anything. Bundle size is basically unchanged, dependencies are just shifted around a little, hardly any perf improvement. Issues on this repo are painful to read. Arguing over semantics.

ethangthereal.bsky.social•22 days ago

I don't trust this group in the slightest. More like DOGE style hackers than VoidZero authors. Feels like piggy backing on others work, shuffling the cards and bit and claiming victory. In the meantime not really contributing anything.

43081j.com•30 days ago

interested in code optimisations but not as interested in dependency optimisations (prefer their own authored packages vs others i guess)
some of the code optimisations are also pretty chunky changes so will be difficult to port back over

43081j.com•30 days ago

will work on contributing some of this upstream at some point, but the fork will live on since some dep switches won't be accepted, and some reworks are too big/disruptive to copy across

Comments

Posting Rules

Reply