Hey everyone,after yet another rejection and empty promises that I will receive feedback from the company I applied to,I am reaching out here to all the #programmers to review my coding assignment.I always want to know more and I am open to criticism #iOS #Swift #developer github.com/JanuszPXYZ/P... - ThreadSky

januszcodes.bsky.social • 7 days ago

Hey everyone,after yet another rejection and empty promises that I will receive feedback from the company I applied to,I am reaching out here to all the #programmers to review my coding assignment.I always want to know more and I am open to criticism #iOS #Swift #developer https://github.com/JanuszPXYZ/ProductBrowse

Comments

massicotte.org•6 days ago

I can see you’ve put a tremendous amount of both thought and care into this and I love that!!

I just scanned but I also see pretty reasonable concurrency use. Love that you turned on checking!

massicotte.org•6 days ago

Someone else pointed out the view if thing.

I guess maybe one thing could be that you went too far? I know you are trying to put your best foot forward. But sometimes reviewers can look and feel like perhaps there’s too much structure/design given the scope? A stretch but possible.

januszcodes.bsky.social•6 days ago

Might be! But I had two options for the task: either I send one of my recent apps (which I wasn’t going to do) or I was going to provide my solution for the task. So, if they were open to private projects/apps then I’d assume they’d be okay with how extensive things can be 😄

radmakr.com•6 days ago

This is an interesting perspective. As an interviewer I have personally never faulted someone for doing too much but I could understand that line of thinking. 🤔

januszcodes.bsky.social•6 days ago

Matt! Thank you! I am honestly blown away by all the feedback I am getting. I am applying left and right (have professional experience, it’s not my first rodeo 😅) but the current job landscape leaves me without any feedback, so I am incredibly grateful for anything I can get!

radmakr.com•6 days ago

I’m not at my laptop right now but I’m assuming this compiles and runs on a real device?
What was the role?
Regardless, if I was reviewing code challenge submissions I would absolutely move you forward in the interview process.

A `.if` view modifier is frowned upon. https://github.com/JanuszPXYZ/ProductBrowse/blob/main/ProductBrowse/Extensions/View%2Bif.swift

januszcodes.bsky.social•6 days ago

Tom, thank you soo much for taking a look at it! I really appreciate it! It compiles, I was checking both on physical devices and simulators just to be sure. Moved the whole project to Swift 6 just because I wanted to experiment and play around with strict concurrency. Once again thank you!!

Comments

Posting Rules

Reply