~6.5x speedup on `bluesky-social/social-app` 😎 - ThreadSky

ThreadSky

About ThreadSky

samuel.bsky.team • 12 days ago

~6.5x speedup on `bluesky-social/social-app` 😎

Comments

moi.quentinix.dev•12 days ago

Very cool ! 🤩

futur.blue•12 days ago

wonder how much of that is navigation lmao

distraction.engineer•11 days ago

Definitely cool, but am I misremembering? I could have swore I saw a mention of ESBuild somewhere in the AtProto or Bluesky code. 🤔

samuel.bsky.team•11 days ago

I think the PDS? but we don't use TS for generating code in social-app, we use metro/webpack

distraction.engineer•11 days ago

Ah yes, that explains it. It didn't occur to me that ESBuild might not fit in with the React Native tooling.

samuel.bsky.team•11 days ago

yeah the React Native stack is 100% custom Meta stuff, even the runtime!

mackuba.eu•12 days ago

👀

jonabrams.com•12 days ago

What was the absolute gain?

jakebailey.dev•12 days ago

😎

samuel.bsky.team•12 days ago

extremely cool!!!!

jakebailey.dev•11 days ago

That being said I'm kinda surprised it's not faster on your codebase, probably worth profiling

samuel.bsky.team•11 days ago

happy to help! it spat out a bunch of errors too, which I didn't look very hard into

jakebailey.dev•11 days ago

Knowing those would also be helpful but it's not too hard to clone your repo

however, I need to _not_ nerd snipe myself with this when I have other stuff I'm supposed to do 😑

samuel.bsky.team•11 days ago

I shall take your burden and nerd-snipe myself instead :)

most of the errors were coming from our generated translation files, I think a cjs/esm thing.

one of them was this ts-ignore not working. It's supposed to be silencing the error on the `maxHeight: '90vh'`, but it doesn't seem to be working

Posting Rules

Be respectful to others
No spam or self-promotion
Stay on topic
Follow Bluesky's terms of service

Comments

Posting Rules

Reply