#buildinpublic 11/27 Today's news - a monster pull request. All in a day's work! @arnab.metacast.app good luck reviewing! If you have questions, I'm AFK. - ThreadSky

About ThreadSky

ilya.metacast.app • 185 days ago

#buildinpublic 11/27

Today's news - a monster pull request. All in a day's work!

@arnab.metacast.app good luck reviewing! If you have questions, I'm AFK.

Comments

ilya.metacast.app•185 days ago

Jokes aside, this PR includes a data file that our website's pages are generated from.

The actual code change is 340 lines.

xjoshwalker.bsky.social•185 days ago

Always my favorite type of huge PR

xjoshwalker.bsky.social•185 days ago

Holy moly 🤯

Fix that build check though 😜

ilya.metacast.app•185 days ago

I've just added a comment for why it's so big (before I get some flak from purists of small changes). Yeah, the build check will be addressed.

dimmkirr.com•185 days ago

Well, you are all lucky it hasn't arrived on Friday night with sprint ending on Monday morning 😅...

seandubb.com•185 days ago

*clicks approve without looking* LGTM

ilya.metacast.app•185 days ago

“I don’t always test code but when I do, I do it in production”.

czekaj.us•185 days ago

LGTM

ilya.metacast.app•185 days ago

FWIW, huge PRs tend to get less in-depth reviews because no one wants to spend a week reviewing 40k lines of code. So, they LGTM it and see if it breaks anything 🫣

czekaj.us•185 days ago

Exactly, the larger the PR the easier to just test in prod.

ilya.metacast.app•185 days ago

😂

Posting Rules

Be respectful to others
No spam or self-promotion
Stay on topic
Follow Bluesky's terms of service

Comments

Posting Rules

Reply