@llamaindex.bsky.social Why is the typing of llamaindex workflows so f*ed up. Declaring return types like BaseModel is a really bad idea, because it means you can’t write type safe code against it. Better to not declare types if you don’t know how to. - ThreadSky

About ThreadSky

mrloh.io • 96 days ago

@llamaindex.bsky.social Why is the typing of llamaindex workflows so f*ed up. Declaring return types like BaseModel is a really bad idea, because it means you can’t write type safe code against it. Better to not declare types if you don’t know how to.

Comments

llamaindex.bsky.social•96 days ago

Hi! Can you let us know where you're seeing BaseModel as the return type?

mrloh.io•95 days ago

I moved on to https://ai.pydantic.dev now which looks like it’s built by engineers who actually know modern Python well.

mrloh.io•95 days ago

Also the whole event thing is build in a way that you have to declare types that you don’t adhere to if you use parallel dispatching of events and collecting them. Tons of different examples in the docs and examples raise type errors. It’s embarrassing.

mrloh.io•95 days ago

`llm.structured_predict` wraps an OpenAI method that has proper generics and drops them to return `BaseModel` that is way way worse than returning Any since it means now you can’t use this code without doing a cast or type ignore statement.

llamaindex.bsky.social•95 days ago

Thanks for the bug report!

logan-markewich.bsky.social•94 days ago

https://github.com/run-llama/llama_index/pull/18290

This is definitely more specific feedback than "workflows are broken", thanks! Easy enough fix -- it was already using generics in the base class, some integrations incorrectly overrode it

The nice thing about open-source software is anyone can make a PR 😁

Posting Rules

Be respectful to others
No spam or self-promotion
Stay on topic
Follow Bluesky's terms of service

Comments

Posting Rules

Reply