Using the remix bundler, that was separated just fine. Using the vite bundler, it isn't. And it doesn't give me a nice stack trace either, it just mentioned "Module "stream" has been externalized" as warning in browser console in dev mode, while causing hard issues in production. - ThreadSky

meijer.ws • 84 days ago

Using the remix bundler, that was separated just fine. Using the vite bundler, it isn't. And it doesn't give me a nice stack trace either, it just mentioned "Module "stream" has been externalized" as warning in browser console in dev mode, while causing hard issues in production.

Comments

alem.forge42.dev•84 days ago

Yeah I think what was happening was that it wasn't properly separated but it was bundled and it accidentally just worked.

Their client/server separation became a lot more precise with Vite. I had a lot of server code leaking into the client in the old remix bundler that became aparent on Vite 😅

meijer.ws•84 days ago

That's definitely possible. So now I hate my currently deployed app and the future equally 😆 Thanks.

alem.forge42.dev•84 days ago

That's what I'm here for, to make you cry! 🫡

Jokes aside, I feel your pain, had the same issues when moving from their old compiler to Vite, what I can say from my vast experience with their Vite plugin is that it gets MUCH better from here.

meijer.ws•84 days ago

IMO, this should've been a hard build error. Don't let me build when server code will unintentionally be included in the browser bundle. It's the same thing I hate the new nextjs for.

Also, make it a LOT easier to trace down these things. This is a PITA and has me concerned for the future.

alem.forge42.dev•84 days ago

I think their client/server separation story has gotten much nicer with Vite, but obviously there are always edge cases. IMO your experience sounds like a bug that should be fix rather than expected behavior inside the plugin.

I'm really surprised you had that happen to you after the migration

meijer.ws•84 days ago

Now I have you on the line 😇, do you know if the new 'single fetch', still uses chunk based streaming for `defer` (which isn't called `defer` any more)?

I remember chunk-based streaming not being supported on AWS Lambda; honestly, stepping away from that would be great.

alem.forge42.dev•84 days ago

They now use turbo-stream (https://github.com/jacob-ebey/turbo-stream) to handle everything. You just pass raw promises over the wire and they get encoded/decoded by turbo-stream under the hood.

Here's the relevant part that encodes the stream I believe:
https://github.com/jacob-ebey/turbo-stream/blob/main/src/turbo-stream.ts#L188

jacobparis.com•84 days ago

the treeshaking wasn't reliable with the old esbuild compiler, so on Vite there's a hard rule that all exports in a route must be considered client safe (except the remix loader and action)

https://remix.run/docs/en/main/discussion/server-vs-client#splitting-up-client-and-server-code

Comments

Posting Rules

Reply