Alright, enough procrastinating. It's time for the weekly #bevymergetrain. This time on BlueSky?! (See the end of the thread for an explanation).
Every week, we go over the community-approved #opensource #rustlang #gamedev PRs for #bevy and merge (most of) them in! https://github.com/bevyengine/bevy/pulls?q=is%3Aopen+is%3Apr+label%3AS-Ready-For-Final-Review
Every week, we go over the community-approved #opensource #rustlang #gamedev PRs for #bevy and merge (most of) them in! https://github.com/bevyengine/bevy/pulls?q=is%3Aopen+is%3Apr+label%3AS-Ready-For-Final-Review
Comments
Arc'd assets: a Cart-inspired ideas that I haven't seriously considered. Hmm! Reading the issue, the core problem is reasonable, and the solution is straightforward and well-made. I'm nervous about missing implications though.
Punting to Cart!
And a crunchy ECS PR to follow. Geez. Right in the guts of the ECS here. Motivation is good, I think we have a migration path, and it's reviewed by two contributors I trust a ton. I think we should ship this to the 0.16 release candidate. Merging.
Oh neat, a cleanup for a pathological corner case of one-shot systems. See the linked comment! I'm not convinced the resource-based approach is right long-term (systems as entities?!), but this is much more intuitive. "const asserted to be a ZST": 🤯! Merging.
A very important "fix" for asset preprocessing: default .meta files will no longer be auto-generated. This was extremely polluting, and I'm relatively convinced in part responsible for the poor uptake of this feature (along with lacking docs).
This change has been well made (yay assets contributors finally!) and now that it's no longer overwriting files I think it's good to merge.
I think we (I?) should write some real asset preprocessing docs for the 0.16 release. Waiting for Cart's review: he had a last minute request.
Oh hey, a really cool (and rare) rendering feature simplification. Flat ambient lights can be modelled as a totally uniform environment light map. Change is shockingly simple, and I expect this to be net negative LOC once the deprecated codepaths are removed.
...