Earlier this month, Josh J. Smith, who served five years in the federal prison system on drug charges, was tapped to be deputy director at the agency that had locked him up. The new deputy director’s past incarceration has drawn outrage from some officers — and support from people still inside.