Hmm... Actually it seems it was only properly fixed in 2023 - before then you could add anything after the entire first file and it wouldn't find the difference.
Sorry when I say “current code” what I mean is: the latest release that supports repro builds. Which is two point releases off from what’s in the store. (I think 11.4 something vs 11.6 latest.)
Maybe if I pull from master we’ll also get the latest? We’re trying to follow the instructions though.
Nah, that looks like reasonable "cleanup code to make it idiomatic", since python doesn't need ; as statement separators at end of line but will allow it.
I don't know if _I'm_ missing something, but the full commit appears to have a check downstream, and what this algo seems to be doing is checking for inequality a 4k block at a time.
Comments
In the argument order from docs (https://core.telegram.org/reproducible-builds) it would catch code added to the store app, but not code removed...
Have you gotten the repro builds to actually work? My student is struggling with tooling problems.
Maybe if I pull from master we’ll also get the latest? We’re trying to follow the instructions though.