This V8 upgrade was particularly difficult and overdue but had to be done for v24, and it finally landed 🎉 Now v24 can finally progress after missing the April 23 deadline github.com/nodejs/node/... Some explanations about why it took so long from the parts I know (@targos.dev probably knows more) - ThreadSky

joyeecheung.bsky.social • 54 days ago

This V8 upgrade was particularly difficult and overdue but had to be done for v24, and it finally landed 🎉 Now v24 can finally progress after missing the April 23 deadline https://github.com/nodejs/node/pull/58070

Some explanations about why it took so long from the parts I know (@targos.dev probably knows more)

Comments

joyeecheung.bsky.social•54 days ago

V8 has dropped support for MSVC last year. It has also become unsustainable for Node.js to float any MSVC patches, so we switched completely to ClangCL on Windows for 24 https://github.com/nodejs/build/pull/4067 which lead to a lot of migration work (mostly handled by Stefan Stojanovic)

joyeecheung.bsky.social•54 days ago

One of the last blocker of the upgrade came from MSVC STL (now compiled by ClangCL) leading to a crash on Windows and we ended up just working around it https://github.com/nodejs/node/commit/4d7da6cca1c1a894032b11b19fc707d605f44400

joyeecheung.bsky.social•54 days ago

There are some zlib crashes armv7l and we ended up just demoting it to experimental since it’s already 2025 https://github.com/nodejs/node/pull/58071

joyeecheung.bsky.social•54 days ago

V8 fully switched to isolate-owned CppHeap in 13.6. We needed to migrate some internal APIs as well as upstreaming new V8 APIs to eliminate races from the new ownership model. https://chromium-review.googlesource.com/c/v8/v8/+/6480071

joyeecheung.bsky.social•54 days ago

SmartOS crashes (fixed by @kebe.com) https://github.com/nodejs/node/commit/c951b76a3bee9f7c4d31adb9d75b54b5f569629f

kebe.com•54 days ago

At some point I need convince Node folks to use "illumos" or at least "SmartOS/illumos", since this fix should not only work with SmartOS, but with any illumos distro.

Appreciate your and @targos.dev 's help on this. Now if I can convince V8 to take the post-IBM-large-pointer version of this...

joyeecheung.bsky.social•54 days ago

A deadlock issue has been looming over the CI for years and it's reproducing more frequently with the V8 upgrade due to concurrunt maglev compilation https://github.com/nodejs/node/issues/54918 - we ended up just ignoring it for now for the upgrade, though I have a fix/workaround brewing https://github.com/nodejs/node/pull/58047

jakebailey.dev•54 days ago

I assume this doesn't change NAPI, such that people can still compile against the NAPI headers with MSVC successfully? I assume you didn't switch to the gnu calling convention for Windows or something

joyeecheung.bsky.social•54 days ago

Theoretically yes https://clang.llvm.org/docs/MSVCCompatibility.html

jakebailey.dev•54 days ago

Rust can do it so surely LLVM can since, same thing, I was just curious if the calling convention was still the same, which, it'd have to be so silly question

jakebailey.dev•54 days ago

Then again I think it sort of doesn't matter if you run it all through dlltool or something like that. Was "fun" to attempt to get working for Go code back when we thought using NAPI was viable for the TS Go port

snek.dev•54 days ago

i feel like 13.4 and onwards have been especially painful. each one seems to contain some sort of game breaking bug or huge change to the way v8 works that makes it extremely difficult to upgrade.

jonlocke.bsky.social•49 days ago

Are Meglev and Sparkplug full enabled on Node 24?

joyeecheung.bsky.social•49 days ago

Both are enabled, though concurrent Sparkplug compilation is disabled, though it might be re-enabled in the next 24 release in https://github.com/nodejs/node/pull/58187 now that the type of deadlocks that can be triggered by it may have been gone after https://github.com/nodejs/node/pull/58047

Comments

Posting Rules

Reply