A solid rule of thumb to avoid flaky/unpredictable tests is to avoid magic implicit dependency injection. Meanwhile, the IntelliJ Platform: hold my beer - ThreadSky

About ThreadSky

sebastiano.dev • 95 days ago

A solid rule of thumb to avoid flaky/unpredictable tests is to avoid magic implicit dependency injection.

Meanwhile, the IntelliJ Platform: hold my beer

Comments

kurt.social•95 days ago

Comment manager.getInstance().createComment(CommentTextProvider.generateCommentText(project, "I agree"))

sebastiano.dev•95 days ago

Pretty much. But this happens 6-7 layers away from where you're actually writing code, and it's a "treasure" hunt :)

sebastiano.dev•95 days ago

It's funny that just last week, in the talk I gave on how to test stuff in Studio code, this was the closing remark re: letting IJP leak into your business code and tests...

kurt.social•95 days ago

What particularly sucks is when your well-written test doesn't work because the platform secretly switched out the implementation for you because isInUnitTestMode(). 🫠

sebastiano.dev•95 days ago

A timeless classic. Today I found some tests that pass only when you run the entire module. This is because side effects from IJP tests in the module mean an EP accessed in the ctor for a data class (🫣) a few levels down is initialised elsewhere, so it somehow works.

Gotta love them footguns.

sebastiano.dev•95 days ago

Needless to say that WhateverWhateverProvider.getInstance().getValue() default value is now gone from the data class ctor, and it's an explicit dependency of the class that creates the instance.

kurt.social•95 days ago

🦶🔫

rahulrav.com•95 days ago

Dependency injection is a good idea but things seem to go sideways very fast in every code base that's had it (that I have touched). Maybe I am set in my ways, but I like constructors. No magic whatsoever.

sebastiano.dev•95 days ago

Agreed. I'll only accept DI that goes through a ctor. I'll let it provide default values for secondary ctors, even :D but that's where I'll stop

Posting Rules

Be respectful to others
No spam or self-promotion
Stay on topic
Follow Bluesky's terms of service

Comments

Posting Rules

Reply