very unfortunate CBOR parsing bug this likely broke all firehose consumers using the Typescript libraries just published the fix: github.com/bluesky-soci... - ThreadSky

About ThreadSky

dholms.xyz • 120 days ago

very unfortunate CBOR parsing bug

this likely broke all firehose consumers using the Typescript libraries

just published the fix:

https://github.com/bluesky-social/atproto/pull/3481

Comments

dholms.xyz•120 days ago

Depending on what lib you're using, you'll want to upgrade to:
- `@atproto/[email protected]`
- `@atproto/[email protected]`
- `@atproto/[email protected]`

dholms.xyz•120 days ago

Also updated the feed-generator template: https://github.com/bluesky-social/feed-generator/pull/135

dholms.xyz•120 days ago

The short of the bug is: our CBOR library was parsing anything over `2^32` (even safe JS ints) as a bigint rather than as a number. The lexicon validation code expected javascript numbers and was therefore failing

Again big apologies to anyone that is affected by this 🙏

retr0.id•120 days ago

2^32 ought to be enough for anyone

retr0.id•120 days ago

this is very much in the "nice problems to have" category - 2^32 events is huge!

dholms.xyz•120 days ago

no one has ever found a use for numbers larger than 2^32

cursed.monster•120 days ago

2^32-1

henryhill1.bsky.social•120 days ago

I hope it's feeling better now.

emilyliu.me•120 days ago

rekt

huwupy.kawaii.social•120 days ago

Common cbor L

sneakyness.com•120 days ago

it would be extremely funny if this is the reason the bot spam stopped

mary.my.id•120 days ago

oooh i was wondering why it was even a problem at all, i forgot that atproto makes use of cbor-x and cborg at the same time

dholms.xyz•120 days ago

yeah we're planning to get `cbor-x` out of there now that cborg supports concatenated cbor

mdruker.app•119 days ago

I updated my feed generator with this fix and it did start consuming again — but parsing way more slowly than before. Any idea what could be happening?

Posting Rules

Be respectful to others
No spam or self-promotion
Stay on topic
Follow Bluesky's terms of service

Comments

Posting Rules

Reply