hirbod.dev
Full-Stack tech lead with very strong design background / OCD driven development
@expo.dev / reactnative expert + enthusiast
⚡️ hirbod.dev
🐙 https://github.com/hirbod
✖️ https://x.com/hirbod_dev
421 posts
1,794 followers
101 following
Regular Contributor
Active Commenter
comment in response to
post
But I think I get why this isn’t accessible for screen readers. I’m definitely lacking the skill and knowledge when it comes to this whole topic; the do’s and don’ts.
comment in response to
post
Our FeedItem is actually a GestureDetector (handles play/pause and double-tap to like), and the RectButtons are placed on top of it—not even nested in the tree. We do have nested pressables, eg in lists where the whole item opens a sheet, but the avatar inside navigates to the profile instead.
comment in response to
post
I get that, but I believe the „how“ can be optimized
comment in response to
post
I honestly never even thought about accessibility. We even use the NativeView and NativeText components directly to optimize performance by skipping all of that. We iterate so fast in startups, there’s no room for it until we have PMF.
comment in response to
post
Generally speaking, I don’t like these automated and expensive lookups. I’d rather have a dev-only warning that forces users to handle accessibility manually. And lookups should bail out fast and have some railguards.
comment in response to
post
From 300MB to 7GB plus a full hang is even worse. Yeah, it’s not a leak, but an infinite traversal bug. In some very rare and not reliably reproducible cases, nested touchables can trigger this bug and completely freeze the app in our case. Adding a fallback `accessibilityLabel` did the trick.
comment in response to
post
Yes. Since 2.1.7 it’s amazing and fast
comment in response to
post
This is just insane madness :D.. I really need a break from React Native :D
comment in response to
post
Imagine, that change made our app the snappiest and fastest react native app I've ever seen. The fucking FPS counter is finally going up, not down when tapping a button. :D
comment in response to
post
I added a simple "fuck off" as Label and the rare bug is gone. This is just madness and a really bad default by RNGH and React Native. 2/4
comment in response to
post
It looks wrong, I agree. > git reset --hard HEAD~1
comment in response to
post
🤔
comment in response to
post
He said „also example ist best of all worlds“ which I translated to „holy grail“. I am not spreading misinformation
comment in response to
post
Amazing
comment in response to
post
*not lot
comment in response to
post
We are on new arch now and I tell you, it’s lot fun 😩. Many many edge cases but we’re close
comment in response to
post
I try to make a short trip to London while he is there (or vice versa). Maybe coming with family for a weekend
comment in response to
post
Oh Marc provided a fix. I was curious to get some numbers. Our App bundle is too small, the win was very marginal (~2%). 4% for you. Why not.
comment in response to
post
But nice illusion
comment in response to
post
There is none
comment in response to
post
We changed our code to use the exported `NativeText` instead of calling `createElement("RCTText")`, and that seems to have fixed the problem.
comment in response to
post
We're trying to create a repro. We have one reliably in our project, but when we tried to make it a minimal repro, it stopped happening. We need to narrow it down and will get back to you once we have a reproducer.
comment in response to
post
This is the full error:
wrapperError [Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.] [Invariant Violation: View config getter callback for component `RCTText` must be a function (received `undefined`).]
comment in response to
post
This breaks react-native-keyboard-controller with Fabric only.
comment in response to
post
When you say applications, do you mean desktop apps or web apps? If it’s the latter, I believe RN will play a big role here. Universal apps are definitely the future, and PWAs suck. React Native is the best bet (in my opinion).
comment in response to
post
RSD will definitely help unify the API, but the underlying primitives will still be different.
comment in response to
post
Was pretty much equal.
comment in response to
post
Go fuck yourself
comment in response to
post
It’s okayish imho. I’m pretty hooked with Severance
comment in response to
post
Its pretty amazing. Sync measurements with Fabric are also superb!
comment in response to
post
What are you talking? Look at the second post in the thread. I posted many stages
comment in response to
post
Lost my dad in July, now my puppy. My condolences with you
comment in response to
post
When your pup stops eating, you know it’s time. He was barely walking, vomiting often, and hardly touching any food (he also made strange noises from his throat). We tried medication for a couple of months, but eventually, we decided to end his suffering.
comment in response to
post
Also my condolences to you 🙏. I lost my dad at that time, now my second best buddy!
comment in response to
post
💯
comment in response to
post
Oh, it’s the sound of his nails for me too… and every time I step into the kitchen, I find myself looking out for his eyes.
comment in response to
post
He was our second dog. I don’t think I could bear this pain a third time.
comment in response to
post
15 years...